#2 WIP: Some basic refactoring and UI work

Open
itshonza wants to merge 1 commits from itshonza/refactoring-ui into meBarista/master
itshonza commented 5 years ago

A WIP PR with some initial basic refactoring that should make the UI a bit more user-friendly and maintainable.

A couple of updates to make the app iPhone X compatible and avoid letterboxing on bigger screens.

A WIP PR with some initial basic refactoring that should make the UI a bit more user-friendly and maintainable. A couple of updates to make the app iPhone X compatible and avoid letterboxing on bigger screens.
meCoffee commented 5 years ago
Owner

Hi Jan,

Thank you for your input, really appreciated. I have added https://git.mecoffee.nl/meBarista/meBarista_in_Ionic2/src/master/CONTRIBUTING.md to the repo.

I have evaluated your PR and in this form I can not merge it. I am really happy about the iPhoneX stuff ( I have no access to it ).

The UI changes though are not mature yet imho :

  • I think removing the temperature from the top bar is a loss, because when users are browsing other pages ( Timers for example ), they can always be aware of the connection-state and the temperature of course. This is particular an issue with the path I want to take with the integrated manual ( I have done server side fixes to this last week ). It would be nice if the user can install with the integrated installation manual and see connection-state / temperature

  • meBarista is a tool in the selling proces : potential users can try out meBarista without buying meCoffee. In this light I see it as a loss the home screen is 'empty' when not connected.

  • On my 4S, the graph is really really small. This is why the graph is fullscreen/backgrounded on iOS and Android up till now.

  • On my 4S, setpoint and actual don't seem to render ( or are outside the viewport, not sure )

A solution would be to separate the iPhoneX fixes/issues in a separate feature-branch.

And regarding the home-screen : it might be worthwhile to include several, to make it configurable. This way we could ship experimental stuff all the way to production.

Let know what you think,

thanks,

Jan

Hi Jan, Thank you for your input, really appreciated. I have added https://git.mecoffee.nl/meBarista/meBarista_in_Ionic2/src/master/CONTRIBUTING.md to the repo. I have evaluated your PR and in this form I can not merge it. I am really happy about the iPhoneX stuff ( I have no access to it ). The UI changes though are not mature yet imho : - I think removing the temperature from the top bar is a loss, because when users are browsing other pages ( Timers for example ), they can always be aware of the connection-state and the temperature of course. This is particular an issue with the path I want to take with the integrated manual ( I have done server side fixes to this last week ). It would be nice if the user can install with the integrated installation manual and see connection-state / temperature - meBarista is a tool in the selling proces : potential users can try out meBarista without buying meCoffee. In this light I see it as a loss the home screen is 'empty' when not connected. - On my 4S, the graph is really really small. This is why the graph is fullscreen/backgrounded on iOS and Android up till now. - On my 4S, setpoint and actual don't seem to render ( or are outside the viewport, not sure ) A solution would be to separate the iPhoneX fixes/issues in a separate feature-branch. And regarding the home-screen : it might be worthwhile to include several, to make it configurable. This way we could ship experimental stuff all the way to production. Let know what you think, thanks, Jan
This pull request can be merged automatically.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.